Build for linux in ubuntu 20.04 container #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/gh-container
branch
from
a7df5c2 to
34d4f6d
Compare
RebeccaMahany
force-pushed
the
becca/gh-container
branch
2 times, most recently
from
3b55ece to
adc47cb
Compare
RebeccaMahany
force-pushed
the
becca/gh-container
branch
2 times, most recently
from
bb79202 to
d0b5c4b
Compare
RebeccaMahany
force-pushed
the
becca/gh-container
branch
from
d0b5c4b to
c614f41
Compare
RebeccaMahany
force-pushed
the
becca/gh-container
branch
from
b7b4c5d to
ce0eed9
Compare
RebeccaMahany
force-pushed
the
becca/gh-container
branch
from
ce0eed9 to
ffba867
Compare
RebeccaMahany
changed the title
zackattack01
approved these changes
Mar 14, 2025
James-Pickett
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #952.
We need to continue to build for linux on Ubuntu 20.04, but the ubuntu-20.04 runners have been EOL'ed. When researching the linked issue, I found that using an ubuntu:20.04 container was widely regarded as the easiest solution. Accordingly, this PR updates to use an ubuntu:20.04 container for the linux build.
I think ideally we'd maintain a docker image that has the build dependencies (
build-essential ca-certificates openssl git zstd) pre-installed, instead of pulling the image and apt-get installing the small handful of deps we need. This would allow us to skip the extra install steps on each build. Plus, we currently can't run the container as the runner user because we aren't allowed to apt-get install as the runner user -- but if the dependencies were pre-installed in the image, we could run the container as the runner user and thereby avoid theIgnore dubious ownershipworkaround I had to add. However, I think the implementation in this PR is okay for the time being.