Skip to content

ADR for standardizing flagset parsing for launcher, plus an example #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Apr 8, 2025

This PR adds a proposal for standardizing flagset parsing for our subcommands, and as an example, standardizes the uninstall subcommand.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review April 9, 2025 20:17
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write up, thanks for putting this together 🔥

@RebeccaMahany RebeccaMahany changed the title Standardize flagset parsing for launcher ADR for standardizing flagset parsing for launcher, plus an example Apr 10, 2025
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice write up, LGTM!

Copy link
Contributor

@cesarfda cesarfda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for putting this together

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Apr 10, 2025
Merged via the queue into kolide:main with commit 6f4c40c Apr 10, 2025
36 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/flags-standardize branch April 10, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants