Skip to content

Require machine GUID change when detecting hardware change on Windows #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RebeccaMahany
Copy link
Contributor

We found that on Windows, both hardware UUID and the serial can have flaky values -- we knew that the hardware UUID could change frequently without indicating a hardware change, but we also found recently that the serial can also change without indicating a hardware change. Therefore, when performing hardware change detection on Windows, we now require that the machine GUID changed.

Added/updated tests accordingly.

@RebeccaMahany RebeccaMahany added the features-improvements Features and Improvements label Jun 2, 2025
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jun 2, 2025
Merged via the queue into kolide:main with commit 5765ae0 Jun 2, 2025
61 of 62 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/hardware-change-detection-require-machine-guid branch June 2, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features-improvements Features and Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants