Require machine GUID change when detecting hardware change on Windows #2293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that on Windows, both hardware UUID and the serial can have flaky values -- we knew that the hardware UUID could change frequently without indicating a hardware change, but we also found recently that the serial can also change without indicating a hardware change. Therefore, when performing hardware change detection on Windows, we now require that the machine GUID changed.
Added/updated tests accordingly.