Skip to content

TestProc improvements #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2025
Merged

TestProc improvements #2327

merged 4 commits into from
Jun 23, 2025

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jun 23, 2025 •
edited
Loading

  • Updated to use sync.OnceFunc to download the osquery binary (like we already do in the TUF tests) instead of TestMain, in case that’s more reliable or easier to troubleshoot
  • Updated to write a legitimate and parseable config file for config path test
  • Updated config path test to set verbose flag so that we have more osquery logs if/when tests fail

@RebeccaMahany RebeccaMahany added the tests-docs Tests, Docs, and Other No-op Changes label Jun 23, 2025
@RebeccaMahany RebeccaMahany changed the title TestProc TestProc improvements Jun 23, 2025
@RebeccaMahany RebeccaMahany marked this pull request as ready for review June 23, 2025 21:01
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jun 23, 2025
Merged via the queue into kolide:main with commit fd742dc Jun 23, 2025
36 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/TestProc-flakiness branch June 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

Assignees
No one assigned
Labels
tests-docs Tests, Docs, and Other No-op Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @zackattack01