Skip to content

Add .exit command to input in TestProc to ensure that process will shut down #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jun 25, 2025

New theory about test flakiness:

I added some documentation to interactive.go to make it clearer that loadExtensions isn't just loading extensions but also running the server until it is shut down.

To attempt to address the test flakiness, I have added a .exit command to our input, to ensure that the process will shut down so the test can proceed.

@RebeccaMahany RebeccaMahany added the tests-docs Tests, Docs, and Other No-op Changes label Jun 25, 2025
@RebeccaMahany RebeccaMahany force-pushed the becca/TestProc-Shutdown branch from 4df2617 to 8dc1659 Compare June 25, 2025 17:18
@RebeccaMahany RebeccaMahany marked this pull request as ready for review June 25, 2025 17:43
@RebeccaMahany RebeccaMahany changed the title Call server.Shutdown in TestProc to ensure that process will shut down Add .exit command to input in TestProc to ensure that process will shut down Jun 25, 2025
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jun 25, 2025
Merged via the queue into kolide:main with commit 309193d Jun 25, 2025
59 of 61 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/TestProc-Shutdown branch June 25, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-docs Tests, Docs, and Other No-op Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants