Add .exit command to input in TestProc to ensure that process will shut down #2335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New theory about test flakiness:
loadExtensions
is actually a blocking operation, since it callsextensionManagerServer.Start()
StartProcess
doesn't actually return until the process has shut downI added some documentation to interactive.go to make it clearer that
loadExtensions
isn't just loading extensions but also running the server until it is shut down.To attempt to address the test flakiness, I have added a
.exit
command to our input, to ensure that the process will shut down so the test can proceed.