Skip to content

automax: don't round down cpu count #479

@komuw

Description

@komuw

https://github.com/komuw/ong/blob/424f53c696d9f04b5451f11b8e916b096245a392/automax/automaxcpu.go#L63C14-L63C36

See: uber-go/automaxprocs#78

For containers with a fractional CPU limit between 1 and 2 cores, 
the current implementation rounds down GOMAXPROCS to 1, 
which means the container will never use more than 1s of CPU because it has a single active thread, 
and the VPA won't scale it up because it still has resources available.

maxProcs := int(math.Ceil(quota))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions