Skip to content

docs(#3705): document pipeline propagation model#3706

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3705-document-pipeline-propagation
Open

docs(#3705): document pipeline propagation model#3706
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3705-document-pipeline-propagation

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Add a Tekton pipelines section to .cursor/rules/tekton.mdc documenting the copy-on-onboard deployment model. Pipeline definitions are copied to user repos at onboarding and do not auto-propagate, so PRs adding pipeline parameters need a companion migration script in build-pipeline-tasks.

This helps the review agent flag missing migration scripts when pipeline parameters are added or modified.

Assisted-by: Claude Code


Closes #3705

Post-script verification

  • Branch is not main/master (agent/3705-document-pipeline-propagation)
  • Secret scan passed (gitleaks — 6c5b84434ebc3d22154a90aeeed5d668aed81304..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add a Tekton pipelines section to .cursor/rules/tekton.mdc
documenting the copy-on-onboard deployment model. Pipeline
definitions are copied to user repos at onboarding and do
not auto-propagate, so PRs adding pipeline parameters need
a companion migration script in build-pipeline-tasks.

This helps the review agent flag missing migration scripts
when pipeline parameters are added or modified.

Closes #3705

Assisted-by: Claude Code
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 15, 2026 07:54
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 15, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:54 AM UTC · Completed 8:00 AM UTC
Commit: 14477fe · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review of PR #3706

Verdict: Approve · no findings

Summary

This PR adds a "Tekton pipelines" section to .cursor/rules/tekton.mdc documenting the pipeline propagation model — specifically that pipeline definitions are copied to user repos at onboarding and do not auto-propagate, requiring companion migration scripts in konflux-ci/build-pipeline-tasks when pipeline parameters change. The change directly addresses issue #3705, which identified this knowledge gap after the review agent missed flagging a missing migration script on PR #3670.

Dimensions reviewed

Dimension Result
Correctness ✅ All technical claims verified. The pipelines/ directory exists with pipeline definitions. The core-services and fbc-builder variants confirmed to use index-addressed JSON Patch operations (e.g., /spec/params/17, /spec/tasks/3/name), validating the append-only parameter ordering guidance.
Security ✅ No secrets, injection patterns, Unicode steganography, or permission changes. Clean docs-only diff.
Intent & coherence ✅ Change traces directly to issue #3705. Scope exactly matches the proposed content — no scope creep, no extra files modified.
Style & conventions ✅ Heading hierarchy (##/###), bullet style (- ), backtick formatting for paths, and URL reference style all match existing patterns in the file.
Documentation currency ✅ All referenced paths verified: pipelines/ exists, tekton.mdc is already referenced in CLAUDE.md, and the task/init/migrations/ path in build-pipeline-tasks is valid.
Cross-repo contracts ⏭ Skipped — no exported interfaces or API surfaces modified.

Notes

The single unverifiable-from-this-repo claim — that migration scripts live under task/init/migrations/ in konflux-ci/build-pipeline-tasks — is presented with a direct link for reader verification, which is appropriate for cross-repo documentation.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • .cursor/rules/tekton.mdc

Labels: PR is a pure documentation addition to cursor rules.

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment documentation Improvements or additions to documentation labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document pipeline propagation model in cursor rules for review agent awareness

0 participants