Pin to a non-breaking version of setup-envtest #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes-sigs/controller-runtime#2720 The minimum required Go version for setup-envtes was bumped to 1.22, breaking us. Pin to release-0.16, which doesn't use 1.22 yet. It uses 1.21, which is still higher than what we use, but back then Go didn't enforce the version requirement yet. Signed-off-by: Adam Cmiel <[email protected]>
|
rcerven
approved these changes
Mar 26, 2024
tkdchen
approved these changes
Mar 27, 2024
mmorhun
approved these changes
Mar 27, 2024
|
Don't understand why EC failed, all those tasks are there |
|
/retest |
|
Maybe it's failing because the task bundles are outdated? I'll combine this PR with #95 again |
|
Merged in #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes-sigs/controller-runtime#2720
The minimum required Go version for setup-envtes was bumped to 1.22, breaking us. Pin to release-0.16, which doesn't use 1.22 yet. It uses 1.21, which is still higher than what we use, but back then Go didn't enforce the version requirement yet.