fix: remove stale rate-limit error handler from setup-tektoncd step#66
Merged
chmeliik merged 1 commit intoJul 14, 2026
Merged
Conversation
The "Describe setup-tektoncd failure" step was added as a workaround for tektoncd/actions#9, which caused setup-tektoncd to fail silently when hitting GitHub API rate limits. That issue has since been fixed by tektoncd/actions#15 (merged 2026-07-03), which switched pipeline downloads to infra.tekton.dev and added proper error handling with clear messages. The stale fallback step is now harmful: it swallows the real error (e.g. a transient HTTP 502) behind a misleading "rate-limit" message and an unauthenticated GitHub API call that itself can trigger rate limiting. Removing the continue-on-error and the fallback step lets the action's own error output surface directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Víctor M. Múgica <vmugicag@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the GitHub Actions workflow for checking task migration by removing the workaround for setup-tektoncd failures, which included a step to describe failures and a continue-on-error setting. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
chmeliik
approved these changes
Jul 14, 2026
chmeliik
left a comment
chmeliik
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, good to know it's fixed now!
tnevrlka
added a commit
to konflux-ci/build-pipeline-tasks
that referenced
this pull request
Jul 21, 2026
Include konflux-ci/task-repo-shared-ci#66 Signed-off-by: Tomáš Nevrlka <tnevrlka@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error+ "Describe setup-tektoncd failure" fallback step from thecheck-task-migrationworkflow (both the repo CI copy and the cookiecutter template)Why
The stale fallback step is now harmful:
tektoncd/actions/setup-tektoncd@main, the fix (which switched pipeline downloads toinfra.tekton.devand added proper error handling) is already in effect.curl -s https://api.github.com/repos/tektoncd/pipeline/releases/latest) can itself trigger rate limiting, adding noise to the output.With the fix removed,
setup-tektoncd's own error output surfaces directly, giving actionable information about the actual failure.Test plan
setup-tektoncdfailure surfaces the action's own error message instead of the stale rate-limit messageSigned-off-by: Víctor M. Múgica vmugicag@redhat.com
🤖 Generated with Claude Code