Skip to content

Conversation

rhuanhianc
Copy link
Contributor

No description provided.

@rhuanhianc rhuanhianc requested a review from a team as a code owner May 22, 2025 20:59
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 changed the title Fixed extra quotes in sample-provider-settings in Ollama model 🌱 Fixed extra quotes in sample-provider-settings in Ollama model May 22, 2025
Copy link
Member

@jwmatthews jwmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rhuanhianc for the fix

@jwmatthews
Copy link
Member

@rhuanhianc please update the commit to sign it, you can see instructions here:
https://github.com/konveyor/kai/blob/main/CONTRIBUTING.md#sign-your-commits

@sjd78
Copy link
Member

sjd78 commented May 22, 2025

@rhuanhianc - You need to sign your commit to pass the DCO check. Really that just means adding a line to your commit message:

Signed-off-by: [email protected]

(what John said)

@rhuanhianc
Copy link
Contributor Author

Hello! Thanks for the feedback and instructions. I believe I have now updated the commit with the DCO signature. This is my first time contributing a PR and I'm learning the process!

@djzager djzager merged commit a14ad84 into konveyor:main May 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants