🐛 Missing css variables for diff view

[ibolton336]

Address missing css variables. This was causing the context item in the diff legend to appear blank.

Summary by CodeRabbit

• Style
  • Improved the appearance of context legend elements by updating background and border colors for both light and dark themes.
  • Enhanced theme support by adding new global color variables for backgrounds, borders, and text.
  • Updated styling imports to ensure consistent visual presentation across relevant components.

[coderabbitai]

Walkthrough

The changes introduce new and updated CSS styling for components related to file modification display in a web UI. Two TypeScript React components (HunkSelectionInterface.tsx and SingleHunkDisplay.tsx) now import a shared CSS file (modifiedFileMessage.css). The CSS file itself is updated to adjust the background and border styling for the .legend-color.context class, including a new dark mode variant. Additionally, the global stylesheet (index.css) is expanded with new PatternFly CSS custom properties for background, border, and text colors, supporting both light and dark themes.

Estimated code review effort

1 (~2 minutes)

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-22T19_51_13_462Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (1)

webview-ui/src/components/ResolutionsPage/ModifiedFile/HunkSelectionInterface.tsx (1)

5-5: Same import already reviewed in SingleHunkDisplay.tsx

No additional concerns.

🧹 Nitpick comments (2)

webview-ui/src/index.css (1)

68-88: Consider scoping PatternFly token overrides

Adding --pf-global--* variables directly on :root will override the host environment (VS Code) for anything else that consumes PatternFly in the same page.
If the intent is to style only the web-view, consider:

-:root {
+:where(#root) {
   /* new token defs … */
 }

or prefix the variables with an extension-specific namespace to avoid accidental bleed-through when the page loads additional PatternFly content in the future.

webview-ui/src/components/ResolutionsPage/ModifiedFile/modifiedFileMessage.css (1)

582-589: Minor visual tweak

The 2 px border shrinks the 0.75 rem square, making the context swatch visually smaller than the addition/deletion ones (which have no border).
If consistent sizing is desired, bump the element size or use an inset box-shadow instead of an actual border:

-.legend-color.context {
-  background-color: var(--pf-global--BackgroundColor--100);
-  border: 2px solid var(--pf-global--BorderColor--300);
-}
+.legend-color.context {
+  background-color: var(--pf-global--BackgroundColor--100);
+  box-shadow: inset 0 0 0 2px var(--pf-global--BorderColor--300);
+}

Purely cosmetic—feel free to ignore if the current look matches the design spec.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ca41fe and a2a2f10.

📒 Files selected for processing (4)

• webview-ui/src/components/ResolutionsPage/ModifiedFile/HunkSelectionInterface.tsx (1 hunks)
• webview-ui/src/components/ResolutionsPage/ModifiedFile/SingleHunkDisplay.tsx (1 hunks)
• webview-ui/src/components/ResolutionsPage/ModifiedFile/modifiedFileMessage.css (1 hunks)
• webview-ui/src/index.css (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build (windows)
• GitHub Check: Build (macos)
• GitHub Check: Build (linux)

🔇 Additional comments (1)

webview-ui/src/components/ResolutionsPage/ModifiedFile/SingleHunkDisplay.tsx (1)

5-5: ✓ Stylesheet import looks good

Side-effect importing the shared stylesheet keeps styling colocated with the component and the relative path is correct (./modifiedFileMessage.css). Nothing else to flag here.

[djzager]

lgtm