Skip to content

koordlet: fix log typo#1008

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
wangxiaoq:log
Feb 10, 2023
Merged

koordlet: fix log typo#1008
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
wangxiaoq:log

Conversation

@wangxiaoq
Copy link
Contributor

Signed-off-by: Wang Xiaoqiang wangxiaoqiang@qiyi.com

Ⅰ. Describe what this PR does

fix log typo in cpu_suppress.go

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 67.49% // Head: 67.51% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c056bb4) compared to base (16be105).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
+ Coverage   67.49%   67.51%   +0.02%     
==========================================
  Files         249      249              
  Lines       28177    28177              
==========================================
+ Hits        19018    19025       +7     
+ Misses       7855     7848       -7     
  Partials     1304     1304              
Flag Coverage Δ
unittests 67.51% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/cpu_suppress.go 69.87% <100.00%> (ø)
pkg/scheduler/plugins/coscheduling/core/gang.go 76.97% <0.00%> (-0.95%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7adc5f6 into koordinator-sh:main Feb 10, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants