Skip to content

apis: add extension field in DeviceAllocation#1012

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:extend_device_allocations_apis
Feb 14, 2023
Merged

apis: add extension field in DeviceAllocation#1012
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:extend_device_allocations_apis

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Feb 13, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Add extension field in DeviceAllocation to support the DeviceShare plugin in koord-scheduler to custom allocator append custom protocol via DeviceAllocation

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 67.52% // Head: 67.57% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (c4e9fb4) compared to base (7adc5f6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   67.52%   67.57%   +0.04%     
==========================================
  Files         249      251       +2     
  Lines       28177    28354     +177     
==========================================
+ Hits        19026    19159     +133     
- Misses       7850     7883      +33     
- Partials     1301     1312      +11     
Flag Coverage Δ
unittests 67.57% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/system/system_file.go 65.62% <0.00%> (-3.61%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️
pkg/koordlet/resmanager/resmanager.go 55.03% <0.00%> (-0.87%) ⬇️
pkg/koordlet/util/system/config.go 59.57% <0.00%> (-0.85%) ⬇️
pkg/slo-controller/nodeslo/nodeslo_controller.go 45.80% <0.00%> (-0.66%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
pkg/slo-controller/nodeslo/resource_strategy.go 84.51% <0.00%> (-0.10%) ⬇️
pkg/koordlet/util/system/system_resource.go 65.62% <0.00%> (ø)
pkg/koordlet/resmanager/system_config.go 70.17% <0.00%> (ø)
pkg/util/config.go 97.04% <0.00%> (+0.09%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koord-scheduler: add extension field in DeviceAllocation apis: add extension field in DeviceAllocation Feb 13, 2023
@hormes
Copy link
Member

hormes commented Feb 13, 2023

/lgtm

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ddf7ad0 into koordinator-sh:main Feb 14, 2023
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants