runtime-proxy: refactor runtime-proxy service framework#1169
runtime-proxy: refactor runtime-proxy service framework#1169xigang wants to merge 1 commit intokoordinator-sh:mainfrom xigang:refactor/runtime-proxy
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 66.73% 65.82% -0.91%
==========================================
Files 273 285 +12
Lines 29879 30607 +728
==========================================
+ Hits 19939 20147 +208
- Misses 8516 9023 +507
- Partials 1424 1437 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jasonliu747
left a comment
There was a problem hiding this comment.
@xigang thanks for your hard work. Patch coverage is only 18.75%, it would be appreciated if you could add some unit tests to improve it.
okay, I will add some unit tests later:) |
@jasonliu747 @eahydra Added unit tests and local test runtime-proxy service without any problem, please review the code. |
Signed-off-by: xigang <wangxigang2014@gmail.com>
|
/close |
|
@xigang: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ⅰ. Describe what this PR does
runtime-proxy: refactor runtime-proxy service framework.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test