Skip to content

runtime-proxy: refactor runtime-proxy service framework#1169

Closed
xigang wants to merge 1 commit intokoordinator-sh:mainfrom
xigang:refactor/runtime-proxy
Closed

runtime-proxy: refactor runtime-proxy service framework#1169
xigang wants to merge 1 commit intokoordinator-sh:mainfrom
xigang:refactor/runtime-proxy

Conversation

@xigang
Copy link
Contributor

@xigang xigang commented Apr 2, 2023

Ⅰ. Describe what this PR does

runtime-proxy: refactor runtime-proxy service framework.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and honpey April 2, 2023 11:32
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fillzpp, zyecho after the PR has been reviewed.
You can assign the PR to them by writing /assign @fillzpp @zyecho in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.91 ⚠️

Comparison is base (a18df74) 66.73% compared to head (2ed715b) 65.82%.

❗ Current head 2ed715b differs from pull request most recent head c32bf8c. Consider uploading reports for the commit c32bf8c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   66.73%   65.82%   -0.91%     
==========================================
  Files         273      285      +12     
  Lines       29879    30607     +728     
==========================================
+ Hits        19939    20147     +208     
- Misses       8516     9023     +507     
- Partials     1424     1437      +13     
Flag Coverage Δ
unittests 65.82% <25.00%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/koord-runtime-proxy/app/options/flag.go 0.00% <0.00%> (ø)
cmd/koord-runtime-proxy/app/options/options.go 0.00% <0.00%> (ø)
pkg/runtimeproxy/config/config.go 91.07% <ø> (ø)
pkg/runtimeproxy/resexecutor/cri/container.go 70.00% <0.00%> (ø)
pkg/runtimeproxy/resexecutor/cri/pod.go 72.27% <0.00%> (-0.28%) ⬇️
pkg/runtimeproxy/server/cri/image.go 0.00% <0.00%> (ø)
pkg/runtimeproxy/server/cri/runtime.go 0.00% <0.00%> (ø)
pkg/runtimeproxy/utils/utils.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/runtimeproxy/server/docker/handler.go 36.65% <20.00%> (ø)
pkg/runtimeproxy/server/docker/server.go 65.69% <24.24%> (-0.20%) ⬇️
... and 2 more

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xigang
Copy link
Contributor Author

xigang commented Apr 2, 2023

/cc @hormes @FillZpp @ZYecho Take a look.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xigang thanks for your hard work. Patch coverage is only 18.75%, it would be appreciated if you could add some unit tests to improve it.

@koordinator-bot koordinator-bot bot requested a review from ZYecho April 2, 2023 15:34
@xigang
Copy link
Contributor Author

xigang commented Apr 3, 2023

@xigang thanks for your hard work. Patch coverage is only 18.75%, it would be appreciated if you could add some unit tests to improve it.

okay, I will add some unit tests later:)

@koordinator-bot koordinator-bot bot added size/XXL and removed size/XL labels Apr 3, 2023
@xigang
Copy link
Contributor Author

xigang commented Apr 3, 2023

@xigang thanks for your hard work. Patch coverage is only 18.75%, it would be appreciated if you could add some unit tests to improve it.

@jasonliu747 @eahydra Added unit tests and local test runtime-proxy service without any problem, please review the code.

Signed-off-by: xigang <wangxigang2014@gmail.com>
@xigang
Copy link
Contributor Author

xigang commented Apr 11, 2023

/close

@koordinator-bot koordinator-bot bot closed this Apr 11, 2023
@koordinator-bot
Copy link

@xigang: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants