Skip to content

koord-scheduler: fix pods outside the Reservation preempt pods in the Reservation#1197

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_preempt_device
Apr 10, 2023
Merged

koord-scheduler: fix pods outside the Reservation preempt pods in the Reservation#1197
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_preempt_device

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Apr 8, 2023

Ⅰ. Describe what this PR does

The pods outside the Reservation cannot preempt pods in Reservation.

Ⅱ. Does this pull request fix one issue?

fix #1187

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Apr 8, 2023

E2E is being supplemented, submitted later

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (2d6ad79) 65.72% compared to head (409f77f) 65.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   65.72%   65.76%   +0.03%     
==========================================
  Files         290      290              
  Lines       30646    30650       +4     
==========================================
+ Hits        20143    20157      +14     
+ Misses       9023     9016       -7     
+ Partials     1480     1477       -3     
Flag Coverage Δ
unittests 65.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/device_cache.go 87.03% <100.00%> (+0.15%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

… Reservation

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the fix_preempt_device branch from 7f743ec to 409f77f Compare April 8, 2023 07:14
@koordinator-bot koordinator-bot bot added size/XL and removed size/M labels Apr 8, 2023
@eahydra
Copy link
Member Author

eahydra commented Apr 8, 2023

TBR

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ae8355a into koordinator-sh:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] When a Pod preempts a Pod in a Reservation, it frequently preempts and fails to obtain resources

3 participants