koord-manager: refactor config validation by github.com/go-playground#1233
Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom Apr 25, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
- Coverage 66.13% 65.43% -0.71%
==========================================
Files 304 309 +5
Lines 31573 31756 +183
==========================================
- Hits 20882 20778 -104
- Misses 9167 9461 +294
+ Partials 1524 1517 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
chzhj
force-pushed
the
validate_refactor
branch
2 times, most recently
from
4c70cb9 to
4306e47
Compare
saintube
reviewed
Apr 21, 2023
zwzhang0107
changed the title
jasonliu747
changed the title
zwzhang0107
reviewed
Apr 21, 2023
Signed-off-by: chzhj <blueheartcheng@gmail.com>
chzhj
force-pushed
the
validate_refactor
branch
from
b09977c to
4ef89e9
Compare
eahydra
reviewed
Apr 24, 2023
Signed-off-by: chzhj <blueheartcheng@gmail.com>
Contributor
|
/lgtm |
hormes
approved these changes
Apr 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
see #1232
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test