koord-scheduler: support select reservation via reservation affinity#1265
Conversation
|
/hold |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 65.08% 65.01% -0.08%
==========================================
Files 309 309
Lines 32520 32589 +69
==========================================
+ Hits 21167 21188 +21
- Misses 9813 9858 +45
- Partials 1540 1543 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b929fa8 to
3af5c16
Compare
apis/extension/reservation.go
Outdated
There was a problem hiding this comment.
When the Pod declares the annotation, does the selection condition of the Reservation for the Pod still take effect?
There was a problem hiding this comment.
Yes, still take effect. Reservation.Spec.Owners is currently required. If we abandon this required condition, even if the Pod declares the Reservation Affinity Annotation, some strange usages will appear. For example, it is possible that a Reservation can be freely used by Pods other than the target.
3af5c16 to
9698a87
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
9698a87 to
11317c8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
If a pod has an affinity annotation, the pod must be allocated from the reservation, otherwise it stops scheduling.
Ⅱ. Does this pull request fix one issue?
fix #1087 #1256
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test