apis: defined Reservation.Spec.AllocateOnce as pointer #1273
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom May 8, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
- Coverage 65.13% 65.12% -0.02%
==========================================
Files 312 312
Lines 32709 32709
==========================================
- Hits 21306 21302 -4
- Misses 9845 9852 +7
+ Partials 1558 1555 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
fix_reservation_allocateonce_tags
branch
from
6f29c9e to
e0c6d15
Compare
eahydra
changed the title
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Defined Reservation.Spec.AllocateOnce as pointer.
Previously, the default value of AllocateOnce was set to true, but because of the empty tag, AllocateOnce could not be set to false, which caused problems in Reservation reuse scenarios.
In the previous test, this problem was not exposed because the CRD Schema was not updated into test cluster.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test