koord-manager: add controllers options#1274
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom May 9, 2023
Merged
koord-manager: add controllers options#1274koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
+ Coverage 65.11% 65.13% +0.01%
==========================================
Files 312 312
Lines 32709 32709
==========================================
+ Hits 21299 21305 +6
+ Misses 9862 9853 -9
- Partials 1548 1551 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zwzhang0107
reviewed
May 8, 2023
saintube
force-pushed
the
koord-manager-add-controller-register
branch
from
f338082 to
be033d7
Compare
saintube
changed the title
saintube
force-pushed
the
koord-manager-add-controller-register
branch
2 times, most recently
from
2ebf846 to
39f67ee
Compare
zwzhang0107
reviewed
May 9, 2023
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
koord-manager-add-controller-register
branch
from
39f67ee to
1657fbb
Compare
hormes
approved these changes
May 9, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Move the controller registration of the koord-manager into the options pkg instead of the main.go.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test