Skip to content

koord-scheduler: refactor ReservationInfo as public#1280

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:make_reservation_info_as_public
May 10, 2023
Merged

koord-scheduler: refactor ReservationInfo as public#1280
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:make_reservation_info_as_public

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented May 10, 2023

Ⅰ. Describe what this PR does

Export ReservationInfo to facilitate subsequent function evolution.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra requested a review from ZiMengSheng May 10, 2023 02:20
@koordinator-bot koordinator-bot bot requested review from buptcozy and hormes May 10, 2023 02:20
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 42.59% and project coverage change: -0.16 ⚠️

Comparison is base (f377ce8) 64.93% compared to head (09dbf35) 64.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   64.93%   64.77%   -0.16%     
==========================================
  Files         313      313              
  Lines       32938    32938              
==========================================
- Hits        21387    21335      -52     
- Misses       9990    10043      +53     
+ Partials     1561     1560       -1     
Flag Coverage Δ
unittests 64.77% <42.59%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/frameworkext/reservation_info.go 0.00% <0.00%> (ø)
pkg/scheduler/plugins/reservation/transformer.go 65.06% <62.96%> (ø)
pkg/scheduler/plugins/reservation/cache.go 88.57% <90.90%> (ø)
pkg/scheduler/plugins/reservation/nominator.go 61.90% <100.00%> (ø)
pkg/scheduler/plugins/reservation/plugin.go 85.30% <100.00%> (ø)
pkg/scheduler/plugins/reservation/scoring.go 80.58% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZiMengSheng
Copy link
Member

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3c4ddc0 into koordinator-sh:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants