Skip to content

koord-scheduler: refactor deviceShare nodeDevice#1285

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:optimize_deviceshare
May 10, 2023
Merged

koord-scheduler: refactor deviceShare nodeDevice#1285
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:optimize_deviceshare

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented May 10, 2023

Ⅰ. Describe what this PR does

refactor deviceShare nodeDevice

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.05 ⚠️

Comparison is base (a07b144) 64.78% compared to head (bed1143) 64.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
- Coverage   64.78%   64.74%   -0.05%     
==========================================
  Files         313      313              
  Lines       32947    32948       +1     
==========================================
- Hits        21346    21332      -14     
- Misses      10043    10053      +10     
- Partials     1558     1563       +5     
Flag Coverage Δ
unittests 64.74% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/device_cache.go 87.06% <83.33%> (+0.03%) ⬆️
pkg/scheduler/plugins/deviceshare/plugin.go 67.22% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra
Copy link
Member Author

eahydra commented May 10, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 032a328 into koordinator-sh:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants