koord-scheduler: fix duplicate allocate GPU after leader selection changed#1289
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom May 12, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
=======================================
Coverage 64.71% 64.72%
=======================================
Files 313 313
Lines 32978 33011 +33
=======================================
+ Hits 21341 21365 +24
- Misses 10074 10078 +4
- Partials 1563 1568 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…anged Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
fix_duplicate_allocate_gpu
branch
from
e0913f5 to
cff9862
Compare
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
The master and slave instances of koord-scheduler both sync pods from api-server via informer and both build nodeDeviceCache with add events. But the slave instance ignore the update event that missed the bound pod by master instance that leaky the pod's deviceAllocations. So if the leader election changed, the slave instance will serve with old states that allocates GPUs that already be allocated for the new Pod.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test