koord-manager: ClusterColocationProfile support grayscale#1322
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom May 24, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
==========================================
- Coverage 64.80% 64.72% -0.08%
==========================================
Files 320 322 +2
Lines 33285 33526 +241
==========================================
+ Hits 21569 21701 +132
- Misses 10142 10253 +111
+ Partials 1574 1572 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ZiMengSheng
force-pushed
the
enhanced_colocation
branch
2 times, most recently
from
0ea04f1 to
8e0bf6c
Compare
ZiMengSheng
changed the title
eahydra
requested changes
May 23, 2023
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
ZiMengSheng
force-pushed
the
enhanced_colocation
branch
from
8e0bf6c to
3e6bcad
Compare
hormes
approved these changes
May 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Add field Probability *intstr.IntOrString in ColocationProfile.Spec. The value range is 0-100. If it's 0, disable the profile; or if it's 100, all Pods can be modified; finnaly, generate a random value like rand.Intn(100), if the value is in 0-targetValue, modify the Pod.
Ⅱ. Does this pull request fix one issue?
fixes #1309
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test