Skip to content

proposal: Node Resource Amplification#1549

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zqzten:node-allocatable-cpu-amplification-proposal
Aug 29, 2023
Merged

proposal: Node Resource Amplification#1549
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zqzten:node-allocatable-cpu-amplification-proposal

Conversation

@zqzten
Copy link
Member

@zqzten zqzten commented Aug 15, 2023

Ⅰ. Describe what this PR does

This PR is the proposal for #1539.

@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng August 15, 2023 12:14
@zqzten zqzten force-pushed the node-allocatable-cpu-amplification-proposal branch from fe179f2 to c43c7fd Compare August 15, 2023 12:16
@zqzten
Copy link
Member Author

zqzten commented Aug 15, 2023

/cc @saintube @hormes

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (8ed0f75) 65.17% compared to head (c9b298e) 65.28%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   65.17%   65.28%   +0.11%     
==========================================
  Files         352      359       +7     
  Lines       36353    36718     +365     
==========================================
+ Hits        23692    23971     +279     
- Misses      10918    10995      +77     
- Partials     1743     1752       +9     
Flag Coverage Δ
unittests 65.28% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zqzten zqzten force-pushed the node-allocatable-cpu-amplification-proposal branch from c43c7fd to bd47fa5 Compare August 16, 2023 03:00
@zqzten zqzten force-pushed the node-allocatable-cpu-amplification-proposal branch 2 times, most recently from 5f976bf to ab945ab Compare August 23, 2023 07:44
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zqzten
Copy link
Member Author

zqzten commented Aug 23, 2023

/assign @hormes

@zqzten zqzten changed the title proposal: Node Allocatable CPU Amplification [WIP] proposal: Node Allocatable CPU Amplification Aug 24, 2023
@zqzten zqzten force-pushed the node-allocatable-cpu-amplification-proposal branch from ab945ab to 2e3b765 Compare August 24, 2023 16:05
@zqzten zqzten changed the title [WIP] proposal: Node Allocatable CPU Amplification proposal: Node Allocatable Resource Amplification Aug 24, 2023
@koordinator-bot koordinator-bot bot removed the request for review from eahydra August 24, 2023 16:07
@koordinator-bot koordinator-bot bot removed the request for review from zwzhang0107 August 24, 2023 16:07
Signed-off-by: Zach Zhu <zzqshu@126.com>
@zqzten zqzten force-pushed the node-allocatable-cpu-amplification-proposal branch from 2e3b765 to c9b298e Compare August 29, 2023 07:21
@zqzten zqzten changed the title proposal: Node Allocatable Resource Amplification proposal: Node Resource Amplification Aug 29, 2023
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 29, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 490dfd6 into koordinator-sh:main Aug 29, 2023
@zqzten zqzten deleted the node-allocatable-cpu-amplification-proposal branch August 29, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants