Skip to content

update LoadAwareScheduling proposal#155

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:update_load_aware_proposal
May 19, 2022
Merged

update LoadAwareScheduling proposal#155
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:update_load_aware_proposal

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented May 19, 2022

Signed-off-by: Tao Li joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Update resource usage estimation in the scoring algorithm and LoadAwareSchedulingArgs

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes May 19, 2022 08:00
Signed-off-by: Tao Li <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the update_load_aware_proposal branch from 2909cdf to baaf64b Compare May 19, 2022 08:03
@eahydra eahydra requested review from jasonliu747 and saintube May 19, 2022 08:05
@codecov-commenter
Copy link

Codecov Report

Merging #155 (2909cdf) into main (889465a) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 2909cdf differs from pull request most recent head baaf64b. Consider uploading reports for the commit baaf64b to get more accurate results

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   56.90%   56.85%   -0.06%     
==========================================
  Files          86       86              
  Lines        7882     7882              
==========================================
- Hits         4485     4481       -4     
- Misses       3004     3006       +2     
- Partials      393      395       +2     
Flag Coverage Δ
unittests 56.85% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slo-controller/nodemetric/nodemetric_controller.go 44.68% <0.00%> (-8.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889465a...baaf64b. Read the comment docs.

@hormes
Copy link
Member

hormes commented May 19, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 803298b into koordinator-sh:main May 19, 2022

- `FilterExpiredNodeMetrics` indicates whether to filter nodes where koordlet fails to update NodeMetric.
- `NodeMetricExpirationSeconds` indicates the NodeMetric expiration in seconds. When NodeMetrics expired, the node is considered abnormal.
- `NodeMetricExpirationSeconds` indicates the NodeMetric expiration in seconds. When NodeMetrics expired, the node is considered abnormal.Default is 180 seconds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the node is considered abnormal. Default is 180 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants