Skip to content

koord-manager: allow quotas that are not bound to pods to become parent nodes#1553

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
xulinfei1996:quota-is-parent
Aug 22, 2023
Merged

koord-manager: allow quotas that are not bound to pods to become parent nodes#1553
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
xulinfei1996:quota-is-parent

Conversation

@xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Aug 16, 2023

Ⅰ. Describe what this PR does

Relax the limit of IsParent change.
If quota is not bound to pods, it can become parent node.
If quota doesn't have children, it can become child node.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 60.97% and project coverage change: +0.01% 🎉

Comparison is base (b791330) 65.04% compared to head (9a48536) 65.05%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   65.04%   65.05%   +0.01%     
==========================================
  Files         352      352              
  Lines       36214    36288      +74     
==========================================
+ Hits        23556    23608      +52     
- Misses      10919    10938      +19     
- Partials     1739     1742       +3     
Flag Coverage Δ
unittests 65.05% <60.97%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/webhook/elasticquota/pod_check.go 71.69% <36.84%> (-19.48%) ⬇️
pkg/webhook/elasticquota/quota_topology.go 67.20% <50.00%> (ø)
pkg/webhook/elasticquota/quota_topology_check.go 75.70% <85.00%> (+2.41%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Aug 17, 2023
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: refine quota webhook check quota topology koord-manager: refine quota webhook check quota topology Aug 17, 2023
@eahydra eahydra changed the title koord-manager: refine quota webhook check quota topology koord-manager: allow quotas that are not bound to Pods to become parent nodes Aug 17, 2023
@eahydra
Copy link
Member

eahydra commented Aug 17, 2023

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 17, 2023
@eahydra eahydra changed the title koord-manager: allow quotas that are not bound to Pods to become parent nodes koord-manager: allow quotas that are not bound to pods to become parent nodes Aug 17, 2023
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

…nt nodes

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 21, 2023
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@shaloulcy
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

@shaloulcy: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hormes
Copy link
Member

hormes commented Aug 22, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants