Skip to content

koord-scheduler: export koordinator-root-quota as CRD object#1555

Merged
koordinator-bot[bot] merged 5 commits intokoordinator-sh:mainfrom
tan90github:feat-AddRootQuota-dev
Aug 30, 2023
Merged

koord-scheduler: export koordinator-root-quota as CRD object#1555
koordinator-bot[bot] merged 5 commits intokoordinator-sh:mainfrom
tan90github:feat-AddRootQuota-dev

Conversation

@tan90github
Copy link
Contributor

Ⅰ. Describe what this PR does

Add the koordinator-root-quota CRD in koordinator.

Ⅱ. Does this pull request fix one issue?

fixes #1519

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 85.41% and no project coverage change.

Comparison is base (b40396d) 65.15% compared to head (2ca5316) 65.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   65.15%   65.16%           
=======================================
  Files         359      359           
  Lines       36738    36783   +45     
=======================================
+ Hits        23936    23968   +32     
- Misses      11053    11062    +9     
- Partials     1749     1753    +4     
Flag Coverage Δ
unittests 65.16% <85.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/webhook/elasticquota/quota_topology_check.go 74.44% <0.00%> (-1.27%) ⬇️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 85.33% <83.33%> (-0.39%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 73.44% <100.00%> (-0.27%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 58.00% <100.00%> (+0.28%) ⬆️
pkg/webhook/elasticquota/quota_topology.go 67.20% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch 7 times, most recently from 7936395 to 288a208 Compare August 18, 2023 11:32
@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch 4 times, most recently from 570e290 to e5f0c37 Compare August 28, 2023 01:25
@tan90github tan90github requested a review from eahydra August 28, 2023 02:11
@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch 3 times, most recently from 7e34072 to c235059 Compare August 29, 2023 01:29
@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch 6 times, most recently from 1df9f74 to 542e9ab Compare August 29, 2023 05:01
@tan90github tan90github requested a review from eahydra August 29, 2023 06:14
@koordinator-bot
Copy link

@tan90github: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch from 0bd910f to fffc9a9 Compare August 29, 2023 08:38
@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch from fffc9a9 to 0da83af Compare August 30, 2023 03:26
@tan90github tan90github requested a review from eahydra August 30, 2023 04:08
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 30, 2023
@eahydra eahydra changed the title koord-scheduler: Add koordinator-root-quota CRD (#1519) koord-scheduler: export koordinator-root-quota as CRD object Aug 30, 2023
Signed-off-by: wangyang55 <wangy9834@163.com>
Signed-off-by: wangyang55 <wangy9834@163.com>
Signed-off-by: wangyang55 <wangy9834@163.com>
Signed-off-by: wangyang55 <wangy9834@163.com>
Signed-off-by: wangyang55 <wangy9834@163.com>
@tan90github tan90github force-pushed the feat-AddRootQuota-dev branch from 0da83af to 2ca5316 Compare August 30, 2023 08:12
@koordinator-bot koordinator-bot bot removed the lgtm label Aug 30, 2023
@tan90github tan90github requested a review from eahydra August 30, 2023 08:18
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 30, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 77aa7e2 into koordinator-sh:main Aug 30, 2023
j4ckstraw pushed a commit to j4ckstraw/koordinator that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[proposal] Add the koordinator-root-quota CRD in koordinator and include the koordinator-root-quota information in quota debug API.

3 participants