koordlet: resource qos config supports SYSTEM qos#1556
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Aug 18, 2023
Merged
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
Contributor
|
/lgtm |
Contributor
|
/approve |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
- Coverage 65.04% 65.02% -0.03%
==========================================
Files 352 352
Lines 36214 36253 +39
==========================================
+ Hits 23556 23573 +17
- Misses 10919 10938 +19
- Partials 1739 1742 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, jasonliu747, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
koordlet: Add the ResourceQOS configurations for qos=SYSTEM pods.
Ⅱ. Does this pull request fix one issue?
When a pod claims its QoSClass as SYSTEM, the current ResourceQOS strategy can fail to parse the config for the pod since there is no SYSTEM class config defined. Especially, it can cause panic when CgroupReconcile is enabled and a SYSTEM pod is running on the node.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test