koord-manager: improve batch resource calculation with system metrics#1559
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Aug 29, 2023
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 65.16% 65.18% +0.01%
==========================================
Files 352 352
Lines 36326 36320 -6
==========================================
+ Hits 23673 23676 +3
+ Misses 10907 10901 -6
+ Partials 1746 1743 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Member
|
/lgtm |
zwzhang0107
reviewed
Aug 22, 2023
pkg/slo-controller/noderesource/plugins/batchresource/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/batchresource/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/batchresource/plugin.go
Outdated
Show resolved
Hide resolved
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
koord-manager-improve-batch-resource
branch
from
3e43455 to
d1b4856
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
j4ckstraw
pushed a commit
to j4ckstraw/koordinator
that referenced
this pull request
Jan 29, 2024
…koordinator-sh#1559) Signed-off-by: saintube <saintube@foxmail.com>
j4ckstraw
reviewed
Feb 20, 2024
| if hasMetric { | ||
| podHPUsed = quotav1.Add(podHPUsed, getPodMetricUsage(podMetric)) | ||
| } else { | ||
| podHPUsed = quotav1.Add(podHPUsed, podRequest) |
Contributor
There was a problem hiding this comment.
why use Request if has no metric, how about skip?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
koord-manager: Improve the calculation of the batch resource allocatable with the newly-added system metrics.
Ⅱ. Does this pull request fix one issue?
Fixes #1427.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
Please note that the calculated allocatable can be lower than the real result at the nodeMetric reported time. It becomes accurate when there are no more pods terminated or newly-scheduled between the nodeMetric reported time and the controller calculating time.
V. Checklist
make test