Skip to content

koord-manager: Add configurable mutating pod update and normalize webhook name#1562

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
FillZpp:add-mutating-pod-update
Aug 21, 2023
Merged

koord-manager: Add configurable mutating pod update and normalize webhook name#1562
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
FillZpp:add-mutating-pod-update

Conversation

@FillZpp
Copy link
Member

@FillZpp FillZpp commented Aug 21, 2023

Ⅰ. Describe what this PR does

Add configurable mutating pod update and normalize webhook name

Ⅱ. Does this pull request fix one issue?

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 38.46% and project coverage change: -0.01% ⚠️

Comparison is base (4682194) 65.04% compared to head (a312923) 65.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   65.04%   65.03%   -0.01%     
==========================================
  Files         352      352              
  Lines       36253    36273      +20     
==========================================
+ Hits        23580    23590      +10     
- Misses      10931    10940       +9     
- Partials     1742     1743       +1     
Flag Coverage Δ
unittests 65.03% <38.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/webhook/pod/mutating/mutating_handler.go 62.50% <38.46%> (-5.69%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the add-mutating-pod-update branch from 7fee9bd to a312923 Compare August 21, 2023 07:17
@eahydra eahydra changed the title Add configurable mutating pod update and normalize webhook name koord-manager: Add configurable mutating pod update and normalize webhook name Aug 21, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ZiMengSheng
Copy link
Member

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f8499a6 into koordinator-sh:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants