Skip to content

koordlet: fix http server with default pprof#1577

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
FillZpp:fix-koordlet-http-server
Aug 25, 2023
Merged

koordlet: fix http server with default pprof#1577
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
FillZpp:fix-koordlet-http-server

Conversation

@FillZpp
Copy link
Member

@FillZpp FillZpp commented Aug 25, 2023

Ⅰ. Describe what this PR does

koordlet: fix http server with default pprof

Ⅱ. Does this pull request fix one issue?

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (6f817dd) 65.16% compared to head (ea72405) 65.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
- Coverage   65.16%   65.14%   -0.02%     
==========================================
  Files         352      352              
  Lines       36336    36336              
==========================================
- Hits        23677    23670       -7     
- Misses      10915    10922       +7     
  Partials     1744     1744              
Flag Coverage Δ
unittests 65.14% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra, jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4bf19ba into koordinator-sh:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants