koord-descheduler: add Arbitrator#1586
Merged
koordinator-bot[bot] merged 7 commits intokoordinator-sh:mainfrom Sep 6, 2023
Merged
koord-descheduler: add Arbitrator#1586koordinator-bot[bot] merged 7 commits intokoordinator-sh:mainfrom
koordinator-bot[bot] merged 7 commits intokoordinator-sh:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 65.22% 65.30% +0.08%
==========================================
Files 368 369 +1
Lines 37971 38117 +146
==========================================
+ Hits 24765 24891 +126
- Misses 11387 11402 +15
- Partials 1819 1824 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eahydra
changed the title
eahydra
reviewed
Sep 4, 2023
pkg/descheduler/controllers/migration/arbitrator/arbitrator_test.go
Outdated
Show resolved
Hide resolved
eahydra
reviewed
Sep 6, 2023
eahydra
reviewed
Sep 6, 2023
eahydra
reviewed
Sep 6, 2023
Signed-off-by: baowj-678 <bwj_678@qq.com>
1. Arbitrator not implements handler.EnqueueRequestForObject; 2. add arbitrationHandler; 3. remove workqueue; 4. others. Signed-off-by: baowj <bwj_678@qq.com>
1. update filter codes. Signed-off-by: baowj <bwj_678@qq.com>
1. delete WithSortFn Signed-off-by: baowj <bwj_678@qq.com>
Co-authored-by: Joseph <joseph.t.lee@outlook.com> Signed-off-by: baowj <bwj_678@qq.com>
Co-authored-by: Joseph <joseph.t.lee@outlook.com> Signed-off-by: baowj <bwj_678@qq.com>
1. update New func; 2. update klog; 3. delete types.go; 4. remove Arbitrator.Create & Arbitrator.Start funcs. Signed-off-by: baowj <bwj_678@qq.com>
baowj-678
force-pushed
the
arbitration_implement
branch
from
8e63725 to
cf57fa6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
j4ckstraw
pushed a commit
to j4ckstraw/koordinator
that referenced
this pull request
May 20, 2024
Signed-off-by: baowj-678 <bwj_678@qq.com> Signed-off-by: baowj <bwj_678@qq.com> Co-authored-by: Joseph <joseph.t.lee@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Implementation of interface
Arbitrator& structarbitratorImplaccording to #1454Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test