apis: update ResourceStatus to support NUMA-aware scheduling#1588
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
- Coverage 65.25% 65.24% -0.01%
==========================================
Files 359 359
Lines 36719 36718 -1
==========================================
- Hits 23960 23957 -3
+ Misses 11011 11009 -2
- Partials 1748 1752 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
91effed to
99cba6d
Compare
|
|
||
| type PodCPUAllocs []PodCPUAlloc | ||
|
|
||
| type CPUSharedPool struct { |
There was a problem hiding this comment.
This share pool is not referenced?
There was a problem hiding this comment.
koordlet only needs to report pools to help diagnose, and koordlet will bind cpus per NUMANode of NUMANodeResources. This is also the current koordlet implementation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
The
ResourceStatusconstrains that the Pod should run on the specified NUMA node, but the original definition cannot support this feature. The definition that records the allocated resources of each NUMA node has therefore been modified.This change requires that the NUMA Node ID reported by koordlet MUST BE unique on that node.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test