Skip to content

apis: update ResourceStatus to support NUMA-aware scheduling#1588

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:support_numaware_s2_1
Aug 29, 2023
Merged

apis: update ResourceStatus to support NUMA-aware scheduling#1588
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:support_numaware_s2_1

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Aug 28, 2023

Ⅰ. Describe what this PR does

The ResourceStatus constrains that the Pod should run on the specified NUMA node, but the original definition cannot support this feature. The definition that records the allocated resources of each NUMA node has therefore been modified.

This change requires that the NUMA Node ID reported by koordlet MUST BE unique on that node.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (8a73b0e) 65.25% compared to head (99cba6d) 65.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   65.25%   65.24%   -0.01%     
==========================================
  Files         359      359              
  Lines       36719    36718       -1     
==========================================
- Hits        23960    23957       -3     
+ Misses      11011    11009       -2     
- Partials     1748     1752       +4     
Flag Coverage Δ
unittests 65.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...scheduler/plugins/nodenumaresource/cpu_topology.go 53.47% <ø> (-0.33%) ⬇️
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 90.62% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_numaware_s2_1 branch from 91effed to 99cba6d Compare August 28, 2023 13:31

type PodCPUAllocs []PodCPUAlloc

type CPUSharedPool struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This share pool is not referenced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

koordlet only needs to report pools to help diagnose, and koordlet will bind cpus per NUMANode of NUMANodeResources. This is also the current koordlet implementation.

@eahydra eahydra requested review from hormes and zwzhang0107 August 29, 2023 02:11
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0b38f96 into koordinator-sh:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants