Skip to content

koord-scheduler: move nodes to GroupQuotaManager#1595

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:move_quota_nodes
Aug 30, 2023
Merged

koord-scheduler: move nodes to GroupQuotaManager#1595
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:move_quota_nodes

Conversation

@shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

move nodes from Plugin to GroupQuotaManager

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from buptcozy and eahydra August 30, 2023 06:18
@eahydra eahydra changed the title move nodes to GroupQuotaManager koord-scheduler: move nodes to GroupQuotaManager Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 24.28% and project coverage change: -0.13% ⚠️

Comparison is base (490dfd6) 65.28% compared to head (0a961e5) 65.16%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
- Coverage   65.28%   65.16%   -0.13%     
==========================================
  Files         359      359              
  Lines       36718    36738      +20     
==========================================
- Hits        23971    23939      -32     
- Misses      10995    11051      +56     
+ Partials     1752     1748       -4     
Flag Coverage Δ
unittests 65.16% <24.28%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...r/plugins/elasticquota/core/group_quota_manager.go 73.71% <5.35%> (-7.59%) ⬇️
pkg/scheduler/plugins/elasticquota/node_handler.go 53.12% <100.00%> (-11.88%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 57.71% <100.00%> (-0.29%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b40396d into koordinator-sh:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants