Skip to content

ci: fix koord-manager role and ignore errors in e2e job #1630

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-koord-manager-nrt-role
Sep 9, 2023
Merged

ci: fix koord-manager role and ignore errors in e2e job #1630
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-koord-manager-nrt-role

Conversation

@saintube
Copy link
Member

@saintube saintube commented Sep 9, 2023

Ⅰ. Describe what this PR does

  1. CI: Mark the E2E status check as optional, postponed to be required when it is complete and optimized.
  2. config: fix the koord-manager role on NodeResourceTopology.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (fb08adc) 65.66% compared to head (44f4be0) 65.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
+ Coverage   65.66%   65.69%   +0.03%     
==========================================
  Files         374      374              
  Lines       39106    39106              
==========================================
+ Hits        25680    25692      +12     
+ Misses      11564    11556       -8     
+ Partials     1862     1858       -4     
Flag Coverage Δ
unittests 65.69% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...er/noderesource/plugins/cpunormalization/plugin.go 87.04% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the fix-koord-manager-nrt-role branch 2 times, most recently from 1b7ced7 to 4068d1f Compare September 9, 2023 07:44
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the fix-koord-manager-nrt-role branch from 4068d1f to 44f4be0 Compare September 9, 2023 07:55
@saintube saintube changed the title ci: fix koord-manager role and mark e2e status check as optional ci: fix koord-manager role and ignore errors in e2e job Sep 9, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4c1cfb3 into koordinator-sh:main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants