Skip to content

koord-scheduler: framework extension executes handler after handling scheduling errors#1633

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:enhance_scheduler_error_handler
Sep 12, 2023
Merged

koord-scheduler: framework extension executes handler after handling scheduling errors#1633
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:enhance_scheduler_error_handler

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Sep 11, 2023

Ⅰ. Describe what this PR does

The framework extension executes handlers after handling scheduling errors to gain the opportunity to affect the scheduling queue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 55.17% and project coverage change: +0.06% 🎉

Comparison is base (a3a6267) 65.77% compared to head (2976a73) 65.83%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
+ Coverage   65.77%   65.83%   +0.06%     
==========================================
  Files         373      375       +2     
  Lines       39378    39515     +137     
==========================================
+ Hits        25899    26013     +114     
- Misses      11598    11619      +21     
- Partials     1881     1883       +2     
Flag Coverage Δ
unittests 65.83% <55.17%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/scheduler/frameworkext/interface.go 0.00% <ø> (ø)
pkg/scheduler/frameworkext/scheduler_adapter.go 0.00% <0.00%> (ø)
.../scheduler/frameworkext/errorhandler_dispatcher.go 100.00% <100.00%> (ø)
.../frameworkext/eventhandlers/reservation_handler.go 53.61% <100.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra force-pushed the enhance_scheduler_error_handler branch from f841366 to eaddc67 Compare September 12, 2023 03:34
@eahydra eahydra requested a review from hormes September 12, 2023 03:35
…dling

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the enhance_scheduler_error_handler branch from eaddc67 to 2976a73 Compare September 12, 2023 04:12
@hormes
Copy link
Member

hormes commented Sep 12, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 17be30b into koordinator-sh:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants