koord-scheduler: NodeNUMAResource only consider allocatable when generating hints#1647
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Sep 14, 2023
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 65.81% 65.78% -0.03%
==========================================
Files 377 377
Lines 39857 39808 -49
==========================================
- Hits 26232 26188 -44
+ Misses 11723 11719 -4
+ Partials 1902 1901 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…rating hints Signed-off-by: Joseph <joseph.t.lee@outlook.com>
18c1162 to
a2a54e9
Compare
Member
|
/lgtm |
hormes
approved these changes
Sep 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
The original implementation of GetPodTopologyHints of NodeNUMAResource provides special processing for CPU-binding scenarios, but this is actually problematic. For example, if a node has two NUMA Nodes, the most CPUs on each NUMA Node are allocated by CPUShare Pods. If we create a LSR Pod at this time, TopologyHint will still be generated, although the allocation will fail in the end. So we need to correct this implementation from the beginning.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test