Skip to content

runtime-manager: refactor codes about store and resource-exectutor#170

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
honpey:runtime-manager-dev
May 25, 2022
Merged

runtime-manager: refactor codes about store and resource-exectutor#170
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
honpey:runtime-manager-dev

Conversation

@honpey
Copy link
Contributor

@honpey honpey commented May 25, 2022

  1. set metaManager as inner class inside store package. other package call store.WritePodSandboxInfo
    directly instead of getting a new Metamanager first.
  2. resource-executor adapts for the new structed PodSandboxInfo/ContianerInfo

Signed-off-by: honpey honpey@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng May 25, 2022 02:54
@honpey honpey force-pushed the runtime-manager-dev branch from 297847f to fa308dc Compare May 25, 2022 02:55
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022 •
edited
Loading

Codecov Report

Merging #170 (06e3658) into main (cb90038) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   57.82%   57.82%           
=======================================
  Files          91       91           
  Lines        8159     8159           
=======================================
  Hits         4718     4718           
  Misses       3029     3029           
  Partials      412      412
Flag Coverage Δ
unittests 57.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb90038...06e3658. Read the comment docs.

@honpey
runtime-manager: refactor codes about store and resource-exectutor
06e3658 
1. set metaManager as inner class inside store package. other package call store.WritePodSandboxInfo
   directly instead of getting a new Metamanager first.
2. resource-executor adapts for the new structed PodSandboxInfo/ContianerInfo

Signed-off-by: honpey <honpey@gmail.com>
@honpey honpey force-pushed the runtime-manager-dev branch from fa308dc to 06e3658 Compare May 25, 2022 05:22
@honpey
Copy link
Contributor Author

honpey commented May 25, 2022

cc @jasonliu747

@hormes
Copy link
Member

hormes commented May 25, 2022

/lgtm
/approve

@hormes
Copy link
Member

hormes commented May 25, 2022

/lgtm
/approve

@koordinator-bot
Copy link

koordinator-bot bot commented May 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 226f8ba into koordinator-sh:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@yihuifeng yihuifeng Awaiting requested review from yihuifeng

Assignees

@hormes hormes

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@honpey @codecov-commenter @hormes