Skip to content

test: add ut for node_event_handler#177

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
jasonliu747:add-ut-2
May 27, 2022
Merged

test: add ut for node_event_handler#177
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
jasonliu747:add-ut-2

Conversation

@jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

add unit test for pkg/slo-controller/nodemetric/node_event_handler.go

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #177 (2dd58b8) into main (25f68bd) will increase coverage by 0.05%.
The diff coverage is 50.00%.

❗ Current head 2dd58b8 differs from pull request most recent head 962fc38. Consider uploading reports for the commit 962fc38 to get more accurate results

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   58.69%   58.75%   +0.05%     
==========================================
  Files          94       94              
  Lines        8615     8615              
==========================================
+ Hits         5057     5062       +5     
+ Misses       3126     3121       -5     
  Partials      432      432              
Flag Coverage Δ
unittests 58.75% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/slo-controller/nodemetric/node_event_handler.go 13.51% <50.00%> (+13.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f68bd...962fc38. Read the comment docs.

@jasonliu747 jasonliu747 requested a review from hormes May 27, 2022 07:45
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@hormes
Copy link
Member

hormes commented May 27, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1fbf748 into koordinator-sh:main May 27, 2022
@jasonliu747 jasonliu747 deleted the add-ut-2 branch May 28, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants