feat: add kubelet http2 support#180
Conversation
There was a problem hiding this comment.
Thanks for your contribution. Please follow the instruction to sign off your commit.
saintube
left a comment
There was a problem hiding this comment.
please don't forget to add unit tests :)
|
@LambdaHJ came up with another soultion. Have you ever tried using token in |
|
As discussed earlier, let's use service account as token to access kubelet. And use apiserver as a failover only when kubelet doesn't work. There might be some pre-conditions to be met for token based authn/authz. For more information, please check https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet-authentication-authorization/ Koordlet needs to reach node address and kubelet port. Addresses and ports are configured in kubelet and published as part of Node object. Addresses in And we can add a command line flag called |
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 58.63% 59.03% +0.40%
==========================================
Files 100 99 -1
Lines 9222 9295 +73
==========================================
+ Hits 5407 5487 +80
+ Misses 3364 3347 -17
- Partials 451 461 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c38fe04 to
ff7e78b
Compare
|
/lgtm |
Signed-off-by: 黄金 <heikkihuang@kugou.net>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jasonliu747
left a comment
There was a problem hiding this comment.
/lgtm
Very nice PR, thanks for your contribution. @LambdaHJ
Signed-off-by: 黄金 <heikkihuang@kugou.net> Co-authored-by: 黄金 <heikkihuang@kugou.net>
Ⅰ. Describe what this PR does
support cce kubernetes cluster kubelet read-only port http2 scheme
Ⅱ. Does this pull request fix one issue?
fixes #150
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews