Skip to content

add more tests#182

Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
hormes:add_more_tests
May 31, 2022
Merged

add more tests#182
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
hormes:add_more_tests

Conversation

@hormes
Copy link
Member

@hormes hormes commented May 30, 2022

Signed-off-by: Fansong Zeng fanster.z@gmail.com

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@koordinator-bot koordinator-bot bot requested review from FillZpp and eahydra May 30, 2022 07:46
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #182 (502a7f7) into main (219a70a) will increase coverage by 1.94%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   58.75%   60.69%   +1.94%     
==========================================
  Files          94       94              
  Lines        8615     8613       -2     
==========================================
+ Hits         5062     5228     +166     
+ Misses       3121     2945     -176     
- Partials      432      440       +8     
Flag Coverage Δ
unittests 60.69% <75.00%> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controller/noderesource/noderesource_controller.go 44.64% <50.00%> (+44.64%) ⬆️
pkg/slo-controller/noderesource/noderesource.go 85.41% <100.00%> (+13.19%) ⬆️
...webhook/pod/mutating/cluster_colocation_profile.go 55.97% <0.00%> (+1.88%) ⬆️
pkg/webhook/pod/mutating/mutating_handler.go 75.00% <0.00%> (+75.00%) ⬆️
...kg/slo-controller/nodemetric/node_event_handler.go 100.00% <0.00%> (+86.48%) ⬆️
pkg/webhook/pod/validating/validating_handler.go 90.00% <0.00%> (+90.00%) ⬆️
...ontroller/noderesource/nodemetric_event_handler.go 90.90% <0.00%> (+90.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219a70a...502a7f7. Read the comment docs.

@jasonliu747
Copy link
Member

Nice! are you going to add more webhoook related test in this PR?
image

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels May 30, 2022
@hormes hormes self-assigned this May 30, 2022
@eahydra
Copy link
Member

eahydra commented May 30, 2022

/lgtm

@hormes
Copy link
Member Author

hormes commented May 31, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c1dc61e into koordinator-sh:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants