koordlet: revise base collectors and system status check#1877
Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom Jan 30, 2024
Merged
Conversation
saintube
force-pushed
the
koordlet-decouple-cuda-image-dependency
branch
from
4611b23 to
b979c33
Compare
saintube
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
+ Coverage 67.26% 67.30% +0.03%
==========================================
Files 411 411
Lines 45857 45875 +18
==========================================
+ Hits 30845 30874 +29
+ Misses 12779 12762 -17
- Partials 2233 2239 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…isabled Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
koordlet-decouple-cuda-image-dependency
branch
from
b979c33 to
eabe076
Compare
saintube
changed the title
saintube
force-pushed
the
koordlet-decouple-cuda-image-dependency
branch
from
6e53bce to
69a209b
Compare
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
koordlet-decouple-cuda-image-dependency
branch
from
69a209b to
4715971
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saintube
added a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…-sh#1877) Signed-off-by: saintube <saintube@foxmail.com>
saintube
added a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: saintube <saintube@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
koordlet:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test