Skip to content

proposal: support Job-level preemption#1879

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
xulinfei1996:eq-job-oversold
Feb 23, 2024
Merged

proposal: support Job-level preemption#1879
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
xulinfei1996:eq-job-oversold

Conversation

@xulinfei1996
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad36a0b) 67.27% compared to head (8cbc460) 67.55%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   67.27%   67.55%   +0.27%     
==========================================
  Files         411      413       +2     
  Lines       45875    46072     +197     
==========================================
+ Hits        30863    31122     +259     
+ Misses      12775    12696      -79     
- Partials     2237     2254      +17     
Flag Coverage Δ
unittests 67.55% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra changed the title add elastic-quota-support-job-level-oversold-management proposal: support Job-level preemption Jan 30, 2024
@xulinfei1996 xulinfei1996 force-pushed the eq-job-oversold branch 4 times, most recently from 2c9afce to d00cd50 Compare February 4, 2024 02:35
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Feb 22, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants