Skip to content

Proposal: add proposal for multi tree quota#1902

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:multi_quota_proposal
Feb 23, 2024
Merged

Proposal: add proposal for multi tree quota#1902
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:multi_quota_proposal

Conversation

@shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

add a proposal for multi tree quota

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (bdaf284) to head (a666496).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         413      413              
  Lines       46072    46229     +157     
==========================================
+ Hits        31124    31230     +106     
- Misses      12693    12730      +37     
- Partials     2255     2269      +14     
Flag Coverage Δ
unittests 67.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@shaloulcy shaloulcy force-pushed the multi_quota_proposal branch from 7963435 to a666496 Compare February 22, 2024 07:14
@koordinator-bot koordinator-bot bot removed the lgtm label Feb 22, 2024
@hormes
Copy link
Member

hormes commented Feb 23, 2024

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 38538a8 into koordinator-sh:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants