Skip to content

scheduler: add unschedulable resource for root quota#1925

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:quota_tree_unhealthy
Feb 28, 2024
Merged

scheduler: add unschedulable resource for root quota#1925
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:quota_tree_unhealthy

Conversation

@shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

export unschedulable resource for root quota

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (d028567) to head (881a7d4).

Files Patch % Lines
pkg/quota-controller/profile/profile_controller.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
+ Coverage   67.50%   67.53%   +0.03%     
==========================================
  Files         416      416              
  Lines       46333    46352      +19     
==========================================
+ Hits        31276    31304      +28     
+ Misses      12781    12775       -6     
+ Partials     2276     2273       -3     
Flag Coverage Δ
unittests 67.53% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Feb 27, 2024

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit fcadf29 into koordinator-sh:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants