Skip to content

add more tests#194

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
hormes:add_more_tests
May 31, 2022
Merged

add more tests#194
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
hormes:add_more_tests

Conversation

@hormes
Copy link
Member

@hormes hormes commented May 31, 2022

Signed-off-by: Fansong Zeng fanster.z@gmail.com

@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng May 31, 2022 04:24
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@hormes hormes self-assigned this May 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #194 (90f1abb) into main (c1dc61e) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   60.96%   61.23%   +0.27%     
==========================================
  Files          97       97              
  Lines        8791     8791              
==========================================
+ Hits         5359     5383      +24     
+ Misses       2983     2958      -25     
- Partials      449      450       +1     
Flag Coverage Δ
unittests 61.23% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod.go 25.50% <ø> (+16.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1dc61e...90f1abb. Read the comment docs.

@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member Author

hormes commented May 31, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit dc28485 into koordinator-sh:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants