Skip to content

koord-runtime-proxy: add installation manual#198

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
honpey:runtime-manager-dev
May 31, 2022
Merged

koord-runtime-proxy: add installation manual#198
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
honpey:runtime-manager-dev

Conversation

@honpey
Copy link
Contributor

@honpey honpey commented May 31, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@koordinator-bot koordinator-bot bot requested review from hormes and yihuifeng May 31, 2022 08:52
@honpey honpey force-pushed the runtime-manager-dev branch 3 times, most recently from 89ae584 to 658d99e Compare May 31, 2022 09:07
@honpey
Copy link
Contributor Author

honpey commented May 31, 2022

/cc @jasonliu747 @eahydra

@koordinator-bot koordinator-bot bot requested review from eahydra and jasonliu747 May 31, 2022 09:20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker not need --remote-image-service-endpoint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for docker,kubelet need to config --docker-endpoint

@honpey honpey force-pushed the runtime-manager-dev branch from 658d99e to 3ecd4b2 Compare May 31, 2022 10:13
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #198 (89ae584) into main (dc28485) will not change coverage.
The diff coverage is n/a.

❗ Current head 89ae584 differs from pull request most recent head ddccd6b. Consider uploading reports for the commit ddccd6b to get more accurate results

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   61.23%   61.23%           
=======================================
  Files          97       97           
  Lines        8791     8791           
=======================================
  Hits         5383     5383           
  Misses       2958     2958           
  Partials      450      450           
Flag Coverage Δ
unittests 61.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc28485...ddccd6b. Read the comment docs.

@jasonliu747 jasonliu747 linked an issue May 31, 2022 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include these commands in code block

@honpey honpey force-pushed the runtime-manager-dev branch from 3ecd4b2 to ddccd6b Compare May 31, 2022 10:32
Signed-off-by: honpey <honpey@gmail.com>
@honpey honpey force-pushed the runtime-manager-dev branch from ddccd6b to 0ea107d Compare May 31, 2022 10:36
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
others PTAL

@hormes
Copy link
Member

hormes commented May 31, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9ebb09c into koordinator-sh:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[proposal] runtime manager deployments manual

5 participants