Skip to content

koordlet: add resctrl qos collector#2005

Merged
koordinator-bot[bot] merged 7 commits intokoordinator-sh:mainfrom
Rouzip:collect
Apr 18, 2025
Merged

koordlet: add resctrl qos collector#2005
koordinator-bot[bot] merged 7 commits intokoordinator-sh:mainfrom
Rouzip:collect

Conversation

@Rouzip
Copy link
Contributor

@Rouzip Rouzip commented Apr 15, 2024

Ⅰ. Describe what this PR does

Add resctrl qos collector.

Ⅱ. Does this pull request fix one issue?

fixes #1832

Ⅲ. Describe how to verify it

After enable resctrl flag in config:

curl http://localhost:9316/metrics|grep resctrl

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 54.09253% with 129 lines in your changes missing coverage. Please review.

Project coverage is 65.96%. Comparing base (83267af) to head (6050553).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
...icsadvisor/collectors/resctrl/resctrl_collector.go 21.05% 60 Missing ⚠️
pkg/koordlet/resourceexecutor/resctrl.go 64.04% 22 Missing and 10 partials ⚠️
pkg/koordlet/metriccache/metric_types.go 0.00% 15 Missing ⚠️
pkg/koordlet/metrics/resctrl.go 0.00% 15 Missing ⚠️
pkg/koordlet/util/system/resctrl.go 90.47% 5 Missing and 1 partial ⚠️
pkg/koordlet/util/system/config.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
- Coverage   67.19%   65.96%   -1.23%     
==========================================
  Files         451      461      +10     
  Lines       43468    54190   +10722     
==========================================
+ Hits        29208    35747    +6539     
- Misses      11714    15876    +4162     
- Partials     2546     2567      +21     
Flag Coverage Δ
unittests 65.96% <54.09%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Rouzip <1226015390@qq.com>
@koordinator-bot koordinator-bot bot added size/XXL and removed size/XL labels May 9, 2024
@Rouzip Rouzip changed the title koordlet: add resctrl qos collector(WIP) koordlet: add resctrl qos collector May 9, 2024
@Rouzip
Copy link
Contributor Author

Rouzip commented May 9, 2024

Sorry for the late pr, any comments is welcome.

Signed-off-by: Rouzip <1226015390@qq.com>
@Rouzip Rouzip force-pushed the collect branch 2 times, most recently from 2d1efd6 to c28c849 Compare May 29, 2024 03:29
@Rouzip
Copy link
Contributor Author

Rouzip commented Jun 25, 2024

hello, PTAL 😊 @saintube

Signed-off-by: Rouzip <1226015390@qq.com>
@saintube
Copy link
Member

@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.

@Rouzip
Copy link
Contributor Author

Rouzip commented Jul 15, 2024

@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.

😊 Anything I can do?

@saintube
Copy link
Member

saintube commented Jul 16, 2024

@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.

😊 Anything I can do?

We will verify this patch on some test environments later. It would also be appreciated if you could add more UTs to increase the patch coverage to no less than the target of 70%.

Signed-off-by: Rouzip <1226015390@qq.com>
Signed-off-by: Frame <saintube@foxmail.com>
Signed-off-by: Frame <saintube@foxmail.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
PTAL /cc @zwzhang0107 @hormes

@saintube saintube added the lgtm label Sep 30, 2024
Signed-off-by: Rouzip <1226015390@qq.com>
@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c0c7698 into koordinator-sh:main Apr 18, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[proposal] QoS class level LLC/MBA metrics collector

4 participants