koordlet: add resctrl qos collector#2005
koordlet: add resctrl qos collector#2005koordinator-bot[bot] merged 7 commits intokoordinator-sh:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 67.19% 65.96% -1.23%
==========================================
Files 451 461 +10
Lines 43468 54190 +10722
==========================================
+ Hits 29208 35747 +6539
- Misses 11714 15876 +4162
- Partials 2546 2567 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rouzip <1226015390@qq.com>
|
Sorry for the late pr, any comments is welcome. |
Signed-off-by: Rouzip <1226015390@qq.com>
2d1efd6 to
c28c849
Compare
|
hello, PTAL 😊 @saintube |
Signed-off-by: Rouzip <1226015390@qq.com>
|
@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged. |
😊 Anything I can do? |
We will verify this patch on some test environments later. It would also be appreciated if you could add more UTs to increase the patch coverage to no less than the target of 70%. |
Signed-off-by: Rouzip <1226015390@qq.com>
Signed-off-by: Frame <saintube@foxmail.com>
Signed-off-by: Frame <saintube@foxmail.com>
saintube
left a comment
There was a problem hiding this comment.
/lgtm
PTAL /cc @zwzhang0107 @hormes
Signed-off-by: Rouzip <1226015390@qq.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saintube, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add resctrl qos collector.
Ⅱ. Does this pull request fix one issue?
fixes #1832
Ⅲ. Describe how to verify it
After enable resctrl flag in config:
curl http://localhost:9316/metrics|grep resctrlⅣ. Special notes for reviews
V. Checklist
make test