Skip to content

scheduler: support pod request exact match reservation#2121

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:mem
Jul 1, 2024
Merged

scheduler: support pod request exact match reservation#2121
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:mem

Conversation

@ZiMengSheng
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@koordinator-bot koordinator-bot bot requested review from FillZpp and buptcozy July 1, 2024 02:01
@codecov
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (5e72bb1) to head (2950892).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/reservation/transformer.go 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   68.68%   68.67%   -0.02%     
==========================================
  Files         430      430              
  Lines       40180    40194      +14     
==========================================
+ Hits        27598    27603       +5     
- Misses      10211    10220       +9     
  Partials     2371     2371              
Flag Coverage Δ
unittests 68.67% <72.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaloulcy
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Member Author

/approve

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 89e9e5c into koordinator-sh:main Jul 1, 2024
@ZiMengSheng ZiMengSheng deleted the mem branch September 12, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants