Skip to content

chore: fix koordlet dockerfile#2134

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:dockerfile-fix-koordlet
Jul 16, 2024
Merged

chore: fix koordlet dockerfile#2134
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:dockerfile-fix-koordlet

Conversation

@saintube
Copy link
Member

@saintube saintube commented Jul 15, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Fixes the E2E failures like:

Run export KUBECONFIG=/home/runner/.kube/config
GOBIN=/home/runner/work/koordinator/koordinator/bin go install github.com/onsi/ginkgo/ginkgo@v1.16.4
Failed to compile e2e:

# github.com/koordinator-sh/koordinator/test/e2e.test
/opt/hostedtoolcache/go/1.20.14/x64/pkg/tool/linux_amd64/link: mapping output file failed: no space left on device

Ginkgo ran 1 suite in 34.075041123s
Test Suite Failed
koord-manager has not restarted
Error: Process completed with exit code 1.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and jasonliu747 July 15, 2024 13:21
@saintube saintube changed the title dockerfile: fix koordlet build chore: fix koordlet dockerfile Jul 15, 2024
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the dockerfile-fix-koordlet branch from 04e9b62 to e97843c Compare July 15, 2024 13:40
@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.90%. Comparing base (632ef28) to head (e97843c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2134   +/-   ##
=======================================
  Coverage   67.89%   67.90%           
=======================================
  Files         441      441           
  Lines       41521    41521           
=======================================
+ Hits        28192    28195    +3     
+ Misses      10902    10901    -1     
+ Partials     2427     2425    -2     
Flag Coverage Δ
unittests 67.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Jul 16, 2024

/lgtm
/approve

@ZiMengSheng
Copy link
Member

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4c38309 into koordinator-sh:main Jul 16, 2024
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants